chore: release workflow fixes #627
Merged
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-627.line-listing.netlify.dhis2.org |
HendrikThePendric
approved these changes
Dec 5, 2024
|
🎉 This PR is included in version 101.1.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 main improvements to the workflow to help solve all the failing builds:
Instead of complex if statements in the gh workflow file (they aren't even working anyway!),
use commit_analyzer config to prevent release for our [skip release] and [skip ci] PRs.
Publishing to AppHub fails if there is no build file, which there won't be in the
case of chores and [skip release]. So add an if statement that checks that a build
was made. The output gets set to "yes" if there is a build.
The report-release-result job should always run. But it should only report a success
message if there is a build and the release step was successful (which is not only
the build file but also whether it was published to apphub)
Here's some workflow outputs from an example app that demonstrate the above changes in a test repo:
build_exists has been set to true and Publish AppHub runs: https://github.com/jenniferarnesen/dhis2-ci-demo/actions/runs/11667460947/job/32484827377
Skip publishing to App hub when [skip release] (even when the commit was a fix or feature): https://github.com/jenniferarnesen/dhis2-ci-demo/actions/runs/11681915720/job/32527955692#step:5:55